Skip to content

Commit 29e40c8

Browse files
darinfcompnerd
authored andcommitted
Fixup the signatures of clearPersistence and terminate (#53)
While the underlying C++ layer does not generate errors for these calls, the Obj C API exposes errors on these calls, so we should here as well.
1 parent f066b39 commit 29e40c8

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

Sources/FirebaseFirestore/Firestore+Swift.swift

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,18 +44,18 @@ public class Firestore {
4444
}
4545
}
4646

47-
public func clearPersistence(completion: (() -> Void)?) {
47+
public func clearPersistence(completion: ((Error?) -> Void)?) {
4848
let future = swift_firebase.swift_cxx_shims.firebase.firestore.firestore_clear_persistence(impl)
4949
future.setCompletion({
5050
if let completion {
5151
DispatchQueue.main.async {
52-
completion()
52+
completion(nil)
5353
}
5454
}
5555
})
5656
}
5757

58-
public func clearPersistence() async {
58+
public func clearPersistence() async throws {
5959
await withCheckedContinuation { continuation in
6060
let future = swift_firebase.swift_cxx_shims.firebase.firestore.firestore_clear_persistence(impl)
6161
future.setCompletion({
@@ -64,18 +64,18 @@ public class Firestore {
6464
}
6565
}
6666

67-
public func terminate(completion: (() -> Void)?) {
67+
public func terminate(completion: ((Error?) -> Void)?) {
6868
let future = swift_firebase.swift_cxx_shims.firebase.firestore.firestore_terminate(impl)
6969
future.setCompletion({
7070
if let completion {
7171
DispatchQueue.main.async {
72-
completion()
72+
completion(nil)
7373
}
7474
}
7575
})
7676
}
7777

78-
public func terminate() async {
78+
public func terminate() async throws {
7979
await withCheckedContinuation { continuation in
8080
let future = swift_firebase.swift_cxx_shims.firebase.firestore.firestore_terminate(impl)
8181
future.setCompletion({

0 commit comments

Comments
 (0)