Include SwiftSyntaxCDataTypes.h in snapshot binary

[vivekg-ai]

The PR swiftlang/swift#39441 has split the SwiftSyntaxParser.h into two parts -

• SwiftSyntaxCDataTypes.h
• SwiftSyntaxParser.h

Include this file SwiftSyntaxCDataTypes.h from release 5.6+

[compnerd]

This isn't really a snapshot binary. This is the installer manifest - it is used for both snapshots and releases. Unless the short description was meant to be that it actually only applies to 5.7?

[compnerd]

Has this file been there since the beginning of time? The installer manifests are shared across versions, and we still have active builds on older releases. Could you please verify that this file exists in 5.3+?

[vivekg-ai]

The new file existence details as below -
5.3 ❌
5.4 ❌
5.5 ❌
5.6 ✔️

So this file started appearing from 5.6 onwards.

[vivekg-ai]

This isn't really a snapshot binary. This is the installer manifest - it is used for both snapshots and releases. Unless the short description was meant to be that it actually only applies to 5.7?

Yeah, I meant it for the 5.7 snapshot. I will correct the description.

[compnerd]

Ah, seems that it was 5.6+ - we should fix this in the 5.6 builds as well. Take a look at: https://github.com/compnerd/swift-build/blob/master/.ci/templates/toolchain-msi.yml#L81-L86
That condition will need to be split, and we can introduce a new HAVE_SWIFT_SYNTAX_CTYPES_HEADER option to include that. That will need to be plumbed through https://github.com/compnerd/swift-build/blob/master/wix/windows-toolchain.wixproj#L27-L35 into the file that you already identified.

[compnerd]

Thanks!