Skip to content

Conversation

@carlos-adir
Copy link
Contributor

@carlos-adir carlos-adir commented Aug 15, 2025

This PR adds a new class USegment which is equivalent to the Segment but doesn't have parameters.

The main motivation is to allow compare two Segment with different parameters.
Example, suppose:

$$p(t) = (1 - t, 2 + 3 t)$$

$$q(t) = (1 - t^3, 2 + 3t^3)$$

We see that $p(t) != q(t)$, but in fact both leads to the same set of points.

With the addition of this class, comparing two JordanCurve instances becomes easier

@carlos-adir carlos-adir self-assigned this Aug 15, 2025
@carlos-adir carlos-adir added the enhancement New feature or request label Aug 15, 2025
@carlos-adir carlos-adir marked this pull request as ready for review August 15, 2025 10:58
@codecov
Copy link

codecov bot commented Aug 15, 2025

Codecov Report

❌ Patch coverage is 99.50739% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 97.87%. Comparing base (30963dc) to head (d6507d1).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/shapepy/geometry/unparam.py 97.87% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
- Coverage   98.12%   97.87%   -0.26%     
==========================================
  Files          28       29       +1     
  Lines        2402     2444      +42     
==========================================
+ Hits         2357     2392      +35     
- Misses         45       52       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@carlos-adir carlos-adir merged commit e161531 into main Aug 15, 2025
9 of 10 checks passed
@carlos-adir carlos-adir deleted the dev/unparametrized branch August 15, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants