Skip to content

Conversation

anutosh491
Copy link
Collaborator

Description

Please include a summary of changes, motivation and context for this PR.

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Added/removed dependencies
  • Required documentation updates

@anutosh491
Copy link
Collaborator Author

As simple cout statements here can show

xeus-cpp/src/xinspect.hpp

Lines 125 to 126 in 53d2f64

std::string tagconf_dir = retrieve_tagconf_dir();
std::string tagfiles_dir = retrieve_tagfile_dir();

image

That the paths we are using are wrong. We just got lucky here as I think as only the last bit of the file path is being used.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.72%. Comparing base (232e345) to head (e99c79a).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #228   +/-   ##
=======================================
  Coverage   80.72%   80.72%           
=======================================
  Files          19       19           
  Lines         970      970           
  Branches       93       93           
=======================================
  Hits          783      783           
  Misses        187      187           
Files with missing lines Coverage Δ
src/xutils.cpp 80.43% <100.00%> (ø)
Files with missing lines Coverage Δ
src/xutils.cpp 80.43% <100.00%> (ø)

@mcbarton mcbarton merged commit 0a9e71e into main Jan 20, 2025
15 checks passed
@vgvassilev vgvassilev deleted the anutosh491-patch-2 branch January 20, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants