Fix github page workflow #191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #191 +/- ##
==========================================
- Coverage 81.10% 80.80% -0.31%
==========================================
Files 19 19
Lines 974 974
Branches 93 93
==========================================
- Hits 790 787 -3
- Misses 184 187 +3 |
anutosh491
reviewed
Dec 5, 2024
| cd $HOME | ||
| git clone https://github.com/emscripten-core/emsdk.git | ||
| cd emsdk | ||
| ./emsdk install ${{ matrix.emsdk_ver }} | ||
|
|
||
| - name: Setup emsdk |
There was a problem hiding this comment.
Can this be removed ? Feels like duplication to me.
There was a problem hiding this comment.
@anutosh491 This is not duplicating anything as far as I can see. This is a separate workflow and setups emsdk the same way the main workflow does.
There was a problem hiding this comment.
Wait I am confused. Looking into your file I see this (probably can expand through view file)
- name: Setup emsdk
shell: bash -l {0}
run: |
cd $HOME
git clone https://github.com/emscripten-core/emsdk.git
cd emsdk
./emsdk install ${{ matrix.emsdk_ver }}
- name: Setup emsdk
shell: bash -l {0}
run: |
emsdk install ${{matrix.emsdk_ver}}
I am just guessing we don't need to do this twice ?
There was a problem hiding this comment.
cc @mcbarton Am I missing something ? Check my comment above
anutosh491
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of changes, motivation and context for this PR.
@anutosh491 The Github page workflow was broken when we stopped using condas emsdk. This PR should fix that.
Fixes # (issue)
Type of change
Please tick all options which are relevant.