Skip to content

Includes must be in this order, windows.h first #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025

Conversation

vgvassilev
Copy link
Contributor

No description provided.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.31%. Comparing base (d6471b9) to head (213d4e8).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #599   +/-   ##
=======================================
  Coverage   77.31%   77.31%           
=======================================
  Files           9        9           
  Lines        3685     3685           
=======================================
  Hits         2849     2849           
  Misses        836      836           
Files with missing lines Coverage Δ
lib/CppInterOp/DynamicLibraryManagerSymbol.cpp 68.01% <ø> (ø)
Files with missing lines Coverage Δ
lib/CppInterOp/DynamicLibraryManagerSymbol.cpp 68.01% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@mcbarton mcbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The Windows jobs pass the ci

@vgvassilev
Copy link
Contributor Author

I guess clang-format sometimes on windows is dangerous :)

@mcbarton mcbarton merged commit de1e51b into compiler-research:main May 28, 2025
78 checks passed
@vgvassilev vgvassilev deleted the fix-windows branch May 28, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants