-
Notifications
You must be signed in to change notification settings - Fork 31
Fix Emscripten workflows #593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Emscripten workflows #593
Conversation
This PR SHOULD NOT be merged in at the moment. It currently points to a fork of Compiler Researchs xeus-cpp to check a fix for the Emscripten workflows in CppInterOp suggested there works. Once the xeus-cpp PR is in I will revert the change which points to the fork, update the deployment workflow and the Emscripten build documentation. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #593 +/- ##
=======================================
Coverage 76.43% 76.43%
=======================================
Files 9 9
Lines 3666 3666
=======================================
Hits 2802 2802
Misses 864 864 🚀 New features to boost your workflow:
|
90a883e
to
f6a424c
Compare
f6a424c
to
be73527
Compare
This PR is now ready for review. The ci should pass for all jobs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Feel free to merge once Ci passes.
Converted to draft for now, as although this will allow the Emscripten workflows to pass, at this moment if merged in CppInterOp will lose all the files added to its deployment (this happened in xeus-cpp recently for unknown reasons). Will relabel as ready for review and merge if @vgvassilev tells me to merge in anyway. |
Merging in now the issue with xeus-cpps deployment has been determined. |
Description
Please include a summary of changes, motivation and context for this PR.
This PR will be used to check if the fix proposed in compiler-research/xeus-cpp#312 will work in fixing the error in CppInterOps Emscripten workflows. Once this xeus-cpp PR is in, I will revert my change which points towards the fork of Compiler Researchs xeus-cpp.
Fixes # (issue)
Type of change
Please tick all options which are relevant.
Testing
Please describe the test(s) that you added and ran to verify your changes.
Checklist