Skip to content

Fix Emscripten workflows #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

mcbarton
Copy link
Collaborator

@mcbarton mcbarton commented May 26, 2025

Description

Please include a summary of changes, motivation and context for this PR.

This PR will be used to check if the fix proposed in compiler-research/xeus-cpp#312 will work in fixing the error in CppInterOps Emscripten workflows. Once this xeus-cpp PR is in, I will revert my change which points towards the fork of Compiler Researchs xeus-cpp.

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Requires documentation updates

Testing

Please describe the test(s) that you added and ran to verify your changes.

Checklist

  • I have read the contribution guide recently

@mcbarton
Copy link
Collaborator Author

mcbarton commented May 26, 2025

This PR SHOULD NOT be merged in at the moment. It currently points to a fork of Compiler Researchs xeus-cpp to check a fix for the Emscripten workflows in CppInterOp suggested there works. Once the xeus-cpp PR is in I will revert the change which points to the fork, update the deployment workflow and the Emscripten build documentation.

Copy link

codecov bot commented May 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.43%. Comparing base (fa1c97d) to head (be73527).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #593   +/-   ##
=======================================
  Coverage   76.43%   76.43%           
=======================================
  Files           9        9           
  Lines        3666     3666           
=======================================
  Hits         2802     2802           
  Misses        864      864           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mcbarton mcbarton force-pushed the Fix-Emscripten-workflows branch from 90a883e to f6a424c Compare May 27, 2025 08:08
@mcbarton mcbarton changed the title [DO NOT MERGE] Fix Emscripten workflows Fix Emscripten workflows May 27, 2025
@mcbarton mcbarton force-pushed the Fix-Emscripten-workflows branch from f6a424c to be73527 Compare May 27, 2025 08:10
@mcbarton mcbarton requested review from vgvassilev and anutosh491 May 27, 2025 08:10
@mcbarton mcbarton marked this pull request as ready for review May 27, 2025 08:11
@mcbarton
Copy link
Collaborator Author

This PR is now ready for review. The ci should pass for all jobs.

Copy link
Collaborator

@anutosh491 anutosh491 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Feel free to merge once Ci passes.

@mcbarton mcbarton marked this pull request as draft May 27, 2025 10:20
@mcbarton
Copy link
Collaborator Author

mcbarton commented May 27, 2025

Converted to draft for now, as although this will allow the Emscripten workflows to pass, at this moment if merged in CppInterOp will lose all the files added to its deployment (this happened in xeus-cpp recently for unknown reasons). Will relabel as ready for review and merge if @vgvassilev tells me to merge in anyway.

@mcbarton mcbarton marked this pull request as ready for review May 27, 2025 11:12
@mcbarton
Copy link
Collaborator Author

Merging in now the issue with xeus-cpps deployment has been determined.

@mcbarton mcbarton merged commit 81cf53a into compiler-research:main May 27, 2025
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants