Enable clang resource dir headers access for cppinterop's deployment #592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcbarton
requested changes
May 26, 2025
There was a problem hiding this comment.
I don't think we should be fetching this package as part of CppInterOps Emscripten build. The ci builds against the head of a release branch, and not a particular release. This could produce an inconsistency I believe (the package also seems to only be available for llvm 20 and not 19). My suggestion is this PR be modified to take advantage of this PR in xeus-cpp once its in compiler-research/xeus-cpp#312 (to be changed later today to clang_resource_dir instead of llvm_resource_dir), and point xeus-cpp in the ci towards the resource directory we already have.
|
Hey @mcbarton check my comment (the second comment) on the xeus-cpp . This was just a dummy PR showing why something like this won't work. Thanks |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should fix the failing CI for cppinterop
Type of change
Please tick all options which are relevant.
Testing
Please describe the test(s) that you added and ran to verify your changes.
Checklist