Use getExecutionEngine to obtain the JIT for Cling > LLVM16
#330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronj0
force-pushed
the
getjit-cling
branch
from
6f3aa37 to
4157cc0
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #330 +/- ##
==========================================
+ Coverage 73.69% 74.27% +0.58%
==========================================
Files 8 8
Lines 3018 3188 +170
==========================================
+ Hits 2224 2368 +144
- Misses 794 820 +26
... and 6 files with indirect coverage changes
|
vgvassilev
reviewed
Sep 30, 2024
lib/Interpreter/Compatibility.h
Outdated
Comment on lines
109
to
116
| #if CLANG_VERSION_MAJOR == 16 | ||
| #ifdef __APPLE__ | ||
| const unsigned m_ExecutorOffset = 62; | ||
| #else | ||
| const unsigned m_ExecutorOffset = 72; | ||
| #endif // __APPLE__ | ||
| #endif |
There was a problem hiding this comment.
How is this block different from the previous?
There was a problem hiding this comment.
The offsets have not yet been updated for cling/llvm 16, will do
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To also be backported to the root-v1.0 tag