Refactored stack and instructions for better encapsulation

Author: apfohl

instructions.c

@@ -5,6 +5,23 @@
 #include "registers.h"
 #include "program.h"
 
+enum instructions {
+    NOP,
+    PUSH,
+    POP,
+    LOAD,
+    STORE,
+    JMP,
+    JZ,
+    JNZ,
+    ADD,
+    SUB,
+    MUL,
+    DIV,
+    PRINT,
+    STOP
+};
+
 uint16_t ip = 0;
 
 void inop(void)

instructions.h

@@ -3,40 +3,6 @@
 
 #include <stdint.h>
 
-enum instructions {
-    NOP,
-    PUSH,
-    POP,
-    LOAD,
-    STORE,
-    JMP,
-    JZ,
-    JNZ,
-    ADD,
-    SUB,
-    MUL,
-    DIV,
-    PRINT,
-    STOP
-};
-
-extern uint16_t ip;
-
-void inop(void);
-void ipush(int32_t element);
-void ipop(void);
-void iload(uint8_t reg);
-void istore(uint8_t reg);
-void ijmp(uint16_t position);
-void ijz(uint16_t position);
-void ijnz(uint16_t position);
-void iadd(void);
-void isub(void);
-void imul(void);
-void idiv(void);
-void iprint(void);
-void istop(void);
-
 void call_instruction(void);
 
 #endif /* end of include guard: INSTRUCTIONS_H */

stack.c

@@ -2,6 +2,8 @@
 #include <stdio.h>
 #include "stack.h"
 
+static const int STACK_SIZE = 256;
+
 int32_t stack[STACK_SIZE];
 uint8_t sp = 0;
 

stack.h

@@ -3,11 +3,6 @@
 
 #include <stdint.h>
 
-static const int STACK_SIZE = 256;
-
-extern int32_t stack[STACK_SIZE];
-extern uint8_t sp;
-
 void stack_push(int32_t element);
 
 int32_t stack_pop(void);