Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New script: ps5-mqtt #1198

Merged
merged 21 commits into from
Jan 9, 2025
Merged

New script: ps5-mqtt #1198

merged 21 commits into from
Jan 9, 2025

Conversation

liecno
Copy link
Contributor

@liecno liecno commented Jan 3, 2025

✍️ Description

Add scripts for PS5-MQTT, useful then using home-assistant core scripts.


🛠️ Type of Change

Please check the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts)

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)
  • Documentation updated (I have updated any relevant documentation)

@liecno liecno requested a review from a team as a code owner January 3, 2025 16:14
@github-actions github-actions bot added new script A change that adds a new script website A change to the website labels Jan 3, 2025
@liecno liecno changed the title Add ps5-mqtt script New script: ps5-mqtt Jan 3, 2025
ct/ps5-mqtt.sh Show resolved Hide resolved
ct/ps5-mqtt.sh Outdated Show resolved Hide resolved
ct/ps5-mqtt.sh Show resolved Hide resolved
ct/ps5-mqtt.sh Outdated Show resolved Hide resolved
install/ps5-mqtt-install.sh Outdated Show resolved Hide resolved
install/ps5-mqtt-install.sh Outdated Show resolved Hide resolved
install/ps5-mqtt-install.sh Outdated Show resolved Hide resolved
install/ps5-mqtt-install.sh Outdated Show resolved Hide resolved
install/ps5-mqtt-install.sh Outdated Show resolved Hide resolved
json/ps5-mqtt.json Outdated Show resolved Hide resolved
@michelroegl-brunner
Copy link
Member

Looks mostly good to me, please remove all blank lines in the msg_info blocks, then it should be good to go.

@liecno
Copy link
Contributor Author

liecno commented Jan 3, 2025

Looks mostly good to me, please remove all blank lines in the msg_info blocks, then it should be good to go.

removed the empty lines in 664f28a. 🚀

ct/ps5-mqtt.sh Outdated Show resolved Hide resolved
ct/ps5-mqtt.sh Outdated Show resolved Hide resolved
ct/ps5-mqtt.sh Show resolved Hide resolved
ct/ps5-mqtt.sh Outdated Show resolved Hide resolved
ct/ps5-mqtt.sh Show resolved Hide resolved
install/ps5-mqtt-install.sh Outdated Show resolved Hide resolved
install/ps5-mqtt-install.sh Show resolved Hide resolved
install/ps5-mqtt-install.sh Outdated Show resolved Hide resolved
install/ps5-mqtt-install.sh Outdated Show resolved Hide resolved
install/ps5-mqtt-install.sh Outdated Show resolved Hide resolved
@liecno liecno requested a review from MickLesk January 6, 2025 17:01
@MickLesk MickLesk merged commit 8dd43dd into community-scripts:main Jan 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new script A change that adds a new script website A change to the website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants