Remove INSTALL_NAME_DIR target property #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using INSTALL_NAME_DIR target property forces the install name to be an
absolute path instead of `@rpath/{target_name}` [1]. This causes problems
when one tries to relocate the target once it is installed.
This patch removes this target property. If a project needs to keep
the absolute path, CMake variables such as INSTALL_NAME_DIR can be set at
configuration to do so.
[1] https://gitlab.kitware.com/cmake/cmake/issues/16589
|
@jcfr Not sure if you had time to review this PR. Just a ping. |
jcfr
added a commit
that referenced
this pull request
Sep 21, 2017
|
Integrated in fa7c647 Note: This change doesn't impact CTK or Slicer since PythonQt is not explicitly installed on MacOSX |
jcfr
added a commit
that referenced
this pull request
Sep 21, 2017
|
Backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using INSTALL_NAME_DIR target property forces the install name to be an
absolute path instead of
@rpath/{target_name}[1]. This causes problemswhen one tries to relocate the target once it is installed.
This patch removes this target property. If a project needs to keep
the absolute path, CMake variables such as INSTALL_NAME_DIR can be set at
configuration to do so.
[1] https://gitlab.kitware.com/cmake/cmake/issues/16589