Fix category edits #1823
Merged
Fix category edits #1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.8-release #1823 +/- ##
==============================================
- Coverage 3.63% 3.63% -0.01%
==============================================
Files 188 188
Lines 9540 9543 +3
Branches 843 843
==============================================
Hits 347 347
- Misses 9169 9172 +3
Partials 24 24
Continue to review full report at Codecov.
|
maskaravivek
force-pushed
the
categoryEdits
branch
from
c978337
to
13c71e1
Compare
|
@misaochan I have rebased the branch. |
|
Tested on API 24 emulator, works well for me. Will be doing a new beta release with this fix shortly. Thanks @maskaravivek ! :) |
misaochan
pushed a commit
to misaochan/apps-android-commons
that referenced
this pull request
Aug 14, 2018
ilgazer
pushed a commit
to ilgazer/apps-android-commons
that referenced
this pull request
Sep 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title (required)
Fixes #1809
Description (required)
Fixes issue where category edits were not going through.
We might have to relook our auth strategy later on but for now, this will surely fix the issue.
Tests performed (required)
Uploaded one image on the beta server.
https://commons.wikimedia.beta.wmflabs.org/wiki/File:Test_65.jpg#filehistory