Skip to content

Conversation

misaochan
Copy link
Member

@misaochan misaochan commented Feb 7, 2018

Hooks up the camera and gallery buttons in Nearby List, as part of the requirement for #252 . Title and desc fields are autofilled, similar in scope to #1060 .

Category suggestions and Wikidata edits have not been implemented.

@commons-app commons-app deleted a comment Feb 7, 2018
@neslihanturan
Copy link
Collaborator

Thanks @misaochan , it works as intended. I restarted Travis CI tests, lets see if it can pass this time.

@neslihanturan
Copy link
Collaborator

Travis logs says:
:app:compileBetaDebugUnitTestJavaWithJavac/home/travis/build/commons-app/apps-android-commons/app/src/test/java/fr/free/nrw/commons/nearby/NearbyAdapterFactoryTest.java:127: error: cannot find symbol private class MockPlaceClickedListener implements PlaceRenderer.PlaceClickedListener { ^ symbol: class PlaceClickedListener location: class PlaceRenderer /home/travis/build/commons-app/apps-android-commons/app/src/test/java/fr/free/nrw/commons/nearby/NearbyAdapterFactoryTest.java:41: error: no suitable constructor found for NearbyAdapterFactory(<null>) NearbyAdapterFactory testObject = new NearbyAdapterFactory(null);

@misaochan
Copy link
Member Author

@neslihanturan Yeah, we need to overhaul several of the Nearby tests before releasing the direct uploads feature. However, I'm not sure if we want to block individual PRs for it? AFAIK some Nearby tests would have failed ever since the UI overhaul at the start of this branch (#1018 ).

@neslihanturan
Copy link
Collaborator

So there is no block to merging it @misaochan :)

@neslihanturan neslihanturan merged commit bd27a01 into commons-app:directNearbyUploads Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants