Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom picker: Allow deeper zoom #5701

Open
nicolas-raoul opened this issue Apr 22, 2024 · 4 comments
Open

Custom picker: Allow deeper zoom #5701

nicolas-raoul opened this issue Apr 22, 2024 · 4 comments

Comments

@nicolas-raoul
Copy link
Member

nicolas-raoul commented Apr 22, 2024

Steps to reproduce:

screen-20240422-204714.mp4

From that screen it is difficult to remember what the picture shows, here is a picture zoomed as deep as possible (on mobile it appears so small that it is impossible to read):

Screenshot_20240422-203951.png

The same picture can be zoomed in much deeper using Google Photos' gallery app:

Screenshot_20240422-204001.png

Similar but different: #1500

@rohit9625
Copy link
Contributor

I want to work on this task 😀

@nicolas-raoul
Copy link
Member Author

@rohit9625 I unassign for now, but if you are you still working on this, please let us know. If no answer, someone else may be assigned to it. Thanks a lot. :-)

@mnalis
Copy link
Contributor

mnalis commented Aug 23, 2024

See idea in linked #5789:

Perhaps we could just call external default gallery/image viewer app (via intent) to display that picture on long-press?
That would be much faster, fix the related zoom bug, give user the choice, and probably reduce the code.

@mnalis
Copy link
Contributor

mnalis commented Aug 23, 2024

Also, panning doesn't seem to work in zoomed image in Custom picker...
Hopefully move to Jetpack Compose mentioned in #5789 (comment) might fix that too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants
@nicolas-raoul @mnalis @rohit9625 and others