Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer rerview deletion requests: Include a link to the policy page #4801

Open
nicolas-raoul opened this issue Feb 7, 2022 · 11 comments
Open

Comments

@nicolas-raoul
Copy link
Member

nicolas-raoul commented Feb 7, 2022

People to whom deletion requests are sent might not be able to understand the language in which the request in written.

So, we should include a link to the policy page, so that they get at least an idea of what it is about.
Policy pages for each deletion reason:

@u7253519
Copy link

Hello, can I try this issue?

@nicolas-raoul
Copy link
Member Author

@u7253519 Thanks! I updated the links above. The first 3 ones are the same URL, but they may be different in the future.

@nicolas-raoul
Copy link
Member Author

@u7253519 Any progress on this? 🙂

@oscols
Copy link

oscols commented Feb 24, 2023

Hi, I am one of the students who wanted to work on this issue.

@nicolas-raoul
Copy link
Member Author

No reply from u7253519.
@oscols It is yours. When do you intend to start working on it?

@nicolas-raoul nicolas-raoul assigned oscols and unassigned u7253519 Feb 24, 2023
@oscols
Copy link

oscols commented Feb 24, 2023

Thank you! We intend to start working on it as soon as possible since the assignment is due next week.

@nicolas-raoul
Copy link
Member Author

Cool! Please let us know about your progress by posting here at least once a week, thanks a good luck!

@JonasHUL
Copy link

Me and the group have sat down and checked the issue. The file deleteHelper seems to be the one that sends the request and we have found a part that adds the delete reason text. Although we have some questions:

The first one: We dont know how to simulate the deletion request, we tried to nominate our own picture for deletion but it did nothing to showcase the problem.

The second one: Is adding the link all we really have to do? It feels like we can just add the link where the list is populated.

The third one: deleteHelper does not have Freedom of panorama as a deletionRequest as we can see?

@nicolas-raoul
Copy link
Member Author

  1. In the app's menu, choose Review, then tap Skip until you see a picture that matches one of the deletion reasons. Then go to the Does this follow the rules of copyright? step and choose a reason. Sorry it might take a lot of time, good thing you are a team of 3 people ;-)

  2. Yes, just add the link. :-) Yes, feel free to add it wherever is the easiest.

  3. You are right, just add the 3 first, and add a comment for the fourth one, this comment will be useful when the 4th reason gets implemented.

Thanks!

@nicolas-raoul nicolas-raoul changed the title Deletion requests: Include a link to the policy page Peer rerview deletion requests: Include a link to the policy page Feb 28, 2023
@JonasHUL
Copy link

JonasHUL commented Mar 3, 2023

We made a quick modification that we believe will solve the issue. However, we were not able to simulate the process of showing the alert.

oscols#9

Thank you for assigning us this issue but the course assignment connected to this issue is done which means that this will be as far as we contribute. If you want we can pull request what we have done however we believe someone has to simulate the alert more and test them before making the change

@nicolas-raoul
Copy link
Member Author

Understood, thank you! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants