Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also consider headquarters location (P159) in Nearby #4444

Open
nicolas-raoul opened this issue Jun 7, 2021 · 0 comments
Open

Also consider headquarters location (P159) in Nearby #4444

nicolas-raoul opened this issue Jun 7, 2021 · 0 comments

Comments

@nicolas-raoul
Copy link
Member

nicolas-raoul commented Jun 7, 2021

Some items have a P159 (headquarters location) with a nested P625, but no P625 (coordinates location).
Example: https://www.wikidata.org/wiki/Q908077

Since such items are rather numerous, we should take them into account in Nearby.

I suggest waiting until Nearby is asynchronous (load items first, then load the properties of each item) before implementing this.
Even then, a first request using P625 and a second request using P159 would be the best to avoid adding request time.

There is no strict consensus on whether such nested coordinates are a good idea or a bad idea, which unfortunately means we should support both:
https://www.wikidata.org/wiki/Wikidata:Project_chat/Archive/2021/03#coordinate_location_(P625)_to_headquarters_location_(P159)_switch
https://www.wikidata.org/wiki/Topic:W5d3dstxpky3z5sl

@nicolas-raoul nicolas-raoul changed the title [far future] Also consider headquarters location (P159) in Nearby Also consider headquarters location (P159) in Nearby May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant