Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rephrase the requirement asking for screenshots in the pull request template #3544

Closed
gupta-anmol opened this issue Mar 18, 2020 · 3 comments · Fixed by #3548
Closed

Rephrase the requirement asking for screenshots in the pull request template #3544

gupta-anmol opened this issue Mar 18, 2020 · 3 comments · Fixed by #3548
Assignees

Comments

@gupta-anmol
Copy link
Contributor

Continuing the discussion from issue #3540

Also, while we are on the subject of making changes to the PR template, can we also modify "Screenshots showing what changed (optional - for UI changes)." I am never sure of what it means. I don't know if I misunderstand it or it could be phrased better. Does it mean this is optional? Does it mean this is optional for UI changes? Does it mean this is optional, but necessary for UI changes?

It means add screenshots if you changed the UI. We could change it to to for UI changes only. Separate issue though, please make an issue to discuss it further

Screenshots showing what changed (optional - for UI changes) can have better phrasing. We could change it to Screenshots showing what changed (for UI changes only).

@sivaraam
Copy link
Member

I believe "Screenshots (for UI changes only)" would be more concise and clear enough.

@macgills
Copy link
Collaborator

@6point022 want this assigned to you?

@gupta-anmol
Copy link
Contributor Author

@macgills Sure. And if we have a consensus on what @sivaraam proposed, i.e., "Screenshots (for UI changes only)", then I'll create a PR for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants