Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Set as Wallpaper" is not working properly #3425

Closed
madhurgupta10 opened this issue Feb 22, 2020 · 3 comments · Fixed by #3427
Closed

"Set as Wallpaper" is not working properly #3425

madhurgupta10 opened this issue Feb 22, 2020 · 3 comments · Fixed by #3427

Comments

@madhurgupta10
Copy link
Collaborator

madhurgupta10 commented Feb 22, 2020

Summary:
"Set as Wallpaper" is not working properly. (Very slow)

Steps to reproduce:
Go to any image and try setting it as a wallpaper using the built-in option.

Device and Android version:
Tested on two devices, Mi A2 on Android 10 and Google Pixel 2 on Android 7

Commons app version:
latest-beta-debug-master

Would you like to work on the issue?
Yes

@maskaravivek
Copy link
Member

Assigned to you.

@madhurgupta10
Copy link
Collaborator Author

@maskaravivek Few things I found:

The set wallpaper is working but not properly, we are unable to see the changes.

  1. If the image is used to set the wallpaper earlier then the wallpaper will set instantaneously. Maybe due to a cached copy.
  2. If it is a new image then it takes a very long time to set the wallpaper, If I close the app before that I guess the process will cancel.

Solution:
I think adding a loader might be a good option, because the time to set wallpaper depends on network speed, size of image and user's phone processor.

@madhurgupta10 madhurgupta10 changed the title "Set as Wallpaper" is not working "Set as Wallpaper" is not working properly Feb 22, 2020
@maskaravivek
Copy link
Member

Yes, you are right. Wallpaper option was added by me as a quick add on (see #1525). Yes it would be great if we could add a loader so that the user knows that something is going on in the background.

Also, a success and failure toast might he helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants