Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enchancement: Preventing multiple clicks on views which open Webview/BrowseIntent #3369

Closed
animeshk08 opened this issue Feb 2, 2020 · 3 comments

Comments

@animeshk08
Copy link
Contributor

Summary:

A lot of views in the application opens BrowseIntent. However, clicking on these views multiple time the intent is also created multiple times which is quite heavy. Hence we can disable the button between successive calls so as to prevent multiple intent calls.
Steps to reproduce:

  1. Click on campaign view multiple times in a short period of time.

Device and Android version:

What make and model device Redmi note7 pro
What Android version Android 9

Commons app version:
2.12.3-debug

Screen-shots:

Would you like to work on the issue?
Yes.

@animeshk08
Copy link
Contributor Author

Sir can I get some inputs on this? @maskaravivek @ashishkumar468 @nicolas-raoul

@nicolas-raoul
Copy link
Member

betaDebug often behaves weirdly.
Could you please send the same screencast with the prodDebug flavor? Thanks :-)

@sivaraam
Copy link
Member

I believe this is obsolete now as #2944 is now fixed. Hence closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants