-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switching to/from night mode causes crash on Nearby tab #3300
Comments
Sure it is allowed:) Welcome to team and thanks for reporting and being volunteer to work on this issue @tmutimer . By the definition the issue seems like suitable for a first time contributor. Please ask if you face with any problem. |
@neslihanturan can I work this issue? |
@gouri-panda Sure. It is yours. :) |
Hi @gouri-panda , We are about to merge a refactor branch of nearby(#3322 ). This issue should not happen any more. I would recommend you to wait for a few days (until that branch is merged) and if the issue still persists, you can surely pick that up :). |
Assigning this to myself to avoid future confusion. |
@ashishkumar468 Sure |
This has been resolved #3322, closing this one. |
Summary:
Toggling the night mode on or off, then navigating back to the nearby screen causes the map to not display properly. Tapping the List button then causes a crash.
Steps to reproduce:
::DEFECT map does not show up. small white square region shows instead in top-right corner.
::DEFECT app crashes
It appears this occurs in NearbyParentFragment.getNearbyMapFragment() - in this method the view and animation variables remain null when the map fragment is reused.
System logs:
MapCrashLog.txt
Device and Android version:
Oneplus 5
Android 9
Stock OxygenOS 9.0.9
Commons app version:
2.12.0-debug-master
Screen-shots:
Would you like to work on the issue?
I would like to work on this myself if possible. This would be my first contribution, so I understand if this is not allowed.
The text was updated successfully, but these errors were encountered: