Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The colorAccent is white in darkMode making toggle switch unidentifiable whether on/off #3249

Closed
ankit1414 opened this issue Nov 30, 2019 · 2 comments · Fixed by #3234
Closed

Comments

@ankit1414
Copy link
Contributor

Summary:

The colorAccent is white in darkMode making toggle switch unidentifiable whether on/off.

Steps to reproduce:

How can we reproduce the issue?
->going to settings from the navigation drawer.

What did you expect the app to do, and what did you see instead?
->The toggle switch should have some color when its on , which gives a better visual effect and easy identification.

Device and Android version:

everywhere

Commons app version:

current master branch

Screen-shots:

photo_2019-11-29_14-50-39

Would you like to work on the issue?

yes

@maskaravivek
Copy link
Member

Thanks for creating the issue @ankit1414. It would be great if you could reference google's material style guide to see what color should be used.

@ankit1414
Copy link
Contributor Author

@maskaravivek i think this is fine considering the app theme.
Hex Code : #108DE8
colorAccent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants