Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display selected place types at top #3242

Open
neslihanturan opened this issue Nov 29, 2019 · 1 comment
Open

Display selected place types at top #3242

neslihanturan opened this issue Nov 29, 2019 · 1 comment

Comments

@neslihanturan
Copy link
Collaborator

Summary:

This was the buggy code I used for this purpose, but should be implemented in a more proper way. Sharing this code piece just to give the idea:

               displayedLabels.remove(label);
                displayedLabels.add(selectedLabels.size()-1, label);
                notifyDataSetChanged();
                smoothScroller.setTargetPosition(0);
                recyclerView.getLayoutManager().startSmoothScroll(smoothScroller);

image

Steps to reproduce:

When you select place types they stay where they are:
image

Ideally the list should be resorted and they should be displayed at the top, and we should make user jump to top after each selection (this behavior is open to discussion, maybe there is no need for this improvement at all. Maybe this is not an improvement already and we should close this issue, please comment) Here is (maybe) expected behavior:
image

Screen-shots:

Can be created by pressing the Volume Down and Power Button at the same time on Android 4.0 and higher.

Would you like to work on the issue?

I shared my buggy solution already. first we should decide if this one is really needed or not, then if it is really needed someone else can start to work on it.

@chaytanyasinha
Copy link

chaytanyasinha commented Dec 4, 2019

Yes @neslihanturan even I have seen this feature in many applications and its very good to have these features as it increases the user experience and make it Comfortable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants