Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nearby map to to get routes and other directional information #2424

Open
cypherop opened this issue Feb 6, 2019 · 4 comments
Open

Use nearby map to to get routes and other directional information #2424

cypherop opened this issue Feb 6, 2019 · 4 comments
Labels

Comments

@cypherop
Copy link
Contributor

cypherop commented Feb 6, 2019

Summary:

When user clicks directions button to get the directions of a location the current action redirects user to google maps. We can implement this feature to get directions in the nearby map. Instead of redirecting the user to the google maps we can show the routes in the nearby map when the user clicks the directions button to get the directions of a location.

Would you like to work on the issue?
Yes

@nicolas-raoul
Copy link
Member

As a heavy user of the app, I often want to open Google Maps in order to get a more detailed map (depending on the country) or to benefit from the satellite view. I almost never need directions, and I guess not many people would think "I want to take a picture of that item so I will take my car or a train to go there".

I agree the icon is a bit misleading, but I believe it is the best way to represent third-party map apps, and for people who want directions they are only a tap away after opening their app.

Alternatively we could have a "third-party map app" icon AND a "directions" icon, but the bar would become a bit crowded. Hiding the Wikipedia and Commons icons if they are disabled (which is the case for most items) could be an idea to make some space.

@cypherop
Copy link
Contributor Author

cypherop commented Feb 7, 2019

Alternatively we could have a "third-party map app" icon AND a "directions" icon, but the bar would become a bit crowded. Hiding the Wikipedia and Commons icons if they are disabled (which is the case for most items) could be an idea to make some space.

In some cases where Wikipedia and Commons icons are not disabled it will become crowded.

@nicolas-raoul
Copy link
Member

Yes, but it is a rare case.
Or we could display icons on two lines (hopefully with some kind of overflowing so that it takes only one line when that fits).

@misaochan
Copy link
Member

I recall we'd discussed implementing directions within the app itself, but IIRC the consensus was that it would be a very involved implementation for minimal benefit. @maskaravivek ?

Hiding the Wikipedia/Commons icons if a page doesn't exist for them would be fantastic, actually! (But probably a separate enhancement, haha).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants