Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace toasts with snackbars where appropriate #2388

Open
ShridharGoel opened this issue Feb 1, 2019 · 12 comments · May be fixed by #5215 or #5585
Open

Replace toasts with snackbars where appropriate #2388

ShridharGoel opened this issue Feb 1, 2019 · 12 comments · May be fixed by #5215 or #5585

Comments

@ShridharGoel
Copy link
Contributor

Summary:

App uses toasts at many places which can be replaced by Snackbars for better UI.

Commons app version:

Latest master

Would you like to work on the issue?

Yes

@ShridharGoel ShridharGoel changed the title Replace all toasts with snackbars Replace toasts with snackbars Feb 1, 2019
@Tanvi-Goyal
Copy link

Hi, i want to work on this issue.

@nicolas-raoul
Copy link
Member

@Tanvi-Goyal
Ah, sorry, Shridhar has mentioned Would you like to work on the issue? Yes but we have forgotten to mark this issue as assigned.
Can you find another unassigned issue?
Sorry about that!

@ShridharGoel
Copy link
Contributor Author

I've already sent a PR which awaits a review.

@madhurgupta10
Copy link
Collaborator

@nicolas-raoul @ShridharGoel I suggest using CSnackBar Library for this task :)

@Rishavgupta12345
Copy link
Contributor

@nicolas-raoul @4D17Y4 I want to work on this issue please assign me

@nicolas-raoul
Copy link
Member

@neslihanturan Do you think this is a good idea, actually? If yes, Rishav can work on it.

@madhurgupta10 Is a library really needed? The PR #2389 does not seem to use any.

@madhurgupta10
Copy link
Collaborator

@nicolas-raoul External library not needed for this task. Also, we should not be replacing every single Toast with Snackbar

Links for reference
https://stackoverflow.com/questions/34432339/android-snackbar-vs-toast-usage-and-difference

https://material.io/archive/guidelines/components/snackbars-toasts.html#:~:text=Snackbars%20contain%20a%20single%20line,not%20be%20swiped%20off%2Dscreen.

Lastly, if someone wants to work on this issue, please also update the unit tests accordingly.

@nicolas-raoul nicolas-raoul changed the title Replace toasts with snackbars Replace toasts with snackbars where appropriate Mar 20, 2022
@nicolas-raoul
Copy link
Member

@Rishavgupta12345 you already have quite a few issues assigned, if you still want to work on this task afterwards please ask again, thanks :-)

@Rishavgupta12345
Copy link
Contributor

@nicolas-raoul @4D17Y4 work on previous issues is completed , please assign me this one

@shankarpriyank
Copy link
Contributor

@nicolas-raoul I guess I will be able to fix the failing tests in #4920.
Can you please assign me this issue?

@neeldoshii
Copy link
Contributor

Hello,
I would like to work on this issue.

Proposed Solution
I would be utilising the util class of snackbar which we have in ViewUtil and replace the Toasts with Snackbar this will allow to make code dry and readable.

Can I get assigned to it? @nicolas-raoul

@neeldoshii neeldoshii linked a pull request Mar 2, 2024 that will close this issue
@nicolas-raoul
Copy link
Member

@shankarpriyank I unassign for now, but if you are you still working on this, please let us know. If no answer, someone else may be assigned to it. Thanks a lot. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment