Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show thanks received #2386

Open
maskaravivek opened this issue Feb 1, 2019 · 13 comments
Open

Show thanks received #2386

maskaravivek opened this issue Feb 1, 2019 · 13 comments

Comments

@maskaravivek
Copy link
Member

Summary:

I recently received my first "Thanks" for a photo uploaded to Commons. It would be great if there's some way for the user to see the "Thanks" that he has received.

In the first cut, it would be nice to open the web page showing the "Thanks logs" filtered for that user.

https://commons.wikimedia.org/wiki/Special:Log?type=thanks&user=&page=User%3AMaskaravivek&wpdate=&tagfilter=

@vanshikaarora
Copy link
Collaborator

@maskaravivek Currently on tapping the notification we are taken to the details of the image uploaded. Shouldn't we add a small SEE YOUR THANKS LOG or such a thing to take the user to the Web page in a webview?

@maskaravivek
Copy link
Member Author

Notifications will show up only when it's unread. I was hoping to have a permanent option.

Maybe we can add it on tap of "Thanks received" in Achievements activity.

@vanshikaarora
Copy link
Collaborator

Maybe we can add it on tap of "Thanks received" in Achievements activity.

Yes that's definitely a good option we can take the user to a separate activity for each of their Thanks Received

Or even we can also add this for each individual image. In thetoolbar for image details activity we can add an icon about the thanks received for that contribution

@cypherop
Copy link
Contributor

cypherop commented Feb 1, 2019

Maybe we can add it on tap of "Thanks received" in Achievements activity.

Maybe on clicking "Thanks received" we can redirect the user on a separate activity containing List of all the thanks received and on clicking on any item in the list the user should be redirected to the details of the image uploaded for which the thanks is received

@cypherop
Copy link
Contributor

cypherop commented Feb 1, 2019

Or even we can also add this for each individual image. In thetoolbar for image details activity we can add an icon about the thanks received for that contribution

Like on Facebook, people get likes which makes them feel good about sharing and on Quora, you get upvotes which makes you want to write more.
We can also show thanks received for each individual images in Home

@nicolas-raoul
Copy link
Member

@maskaravivek Could you please post a screenshot showing how the thank looks like, in your https://commons.wikimedia.org/wiki/Special:Notifications ? Thanks!

@maskaravivek
Copy link
Member Author

screenshot 2019-02-04 at 12 34 47 pm

@nicolas-raoul
Copy link
Member

Does the URL in the issue description also allow to see what picture it was? Apparently not? Might be for privacy reasons, since thanks are public?

@vanshikaarora
Copy link
Collaborator

Does the URL in the issue description also allow to see what picture it was? Apparently not? Might be for privacy reasons, since thanks are public?

@nicolas-raoul Looking at the API available here:
https://commons.wikimedia.org/wiki/Special:ApiSandbox#action=thank&revid=456&source=diff&token=123ABC I can guess that currently the image url is not provided in the API request

but I guess it can be done using

source

diff

A short string describing the source of the request, for example diff or history.

Please correct me if I am wrong here :)

@maskaravivek
Copy link
Member Author

According to the documentation:

The specific revision that is being "thanked" for is not stored in the public logging table. Only the timestamp, sender, and recipient, are publicly logged.

The same can be checked in the database. Any information about the image being thanked is not persisted in the public DB.

https://quarry.wmflabs.org/query/31756

At best, we can simply show a log of thanks received by the user. Am not sure if anyone would be interested in seeing that log without knowing which media was thanked.

@vanshikaarora
Copy link
Collaborator

The specific revision that is being "thanked" for is not stored in the public logging table. Only the timestamp, sender, and recipient, are publicly logged.

  • Presently the app shows the number of thanks received so showing the logs of that "Thanks recieved" might add an additional value for the user
  • Also (This is an optional suggestion) : since we have the timestamp we might be able to retrieve which image we are thanked for and thus give information of the image being thanked

@cypherop
Copy link
Contributor

cypherop commented Feb 4, 2019

The specific revision that is being "thanked" for is not stored in the public logging table. Only the timestamp, sender, and recipient, are publicly logged.

Is this the timestamp at which the thanks was received and not the timestamp at which the image was uploaded? In that case it might not be possible to retrieve which image we are thanked for.

@maskaravivek
Copy link
Member Author

  • Presently the app shows the number of thanks received so showing the logs of that "Thanks recieved" might add an additional value for the user

I am fine with showing the logs but lets other pitch in too. cc @misaochan @neslihanturan @nicolas-raoul
If we go ahead with it,

  • Also (This is an optional suggestion) : since we have the timestamp we might be able to retrieve which image we are thanked for and thus give information of the image being thanked

Yes, as @sp2710 pointed out, this timestamp is for the thanks and not for image upload. So it might not be possible to link it with an image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants