Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dynamic loading of contributions, without number limit #1993

Closed
misaochan opened this issue Nov 10, 2018 · 7 comments · Fixed by #3566
Closed

Allow dynamic loading of contributions, without number limit #1993

misaochan opened this issue Nov 10, 2018 · 7 comments · Fixed by #3566
Assignees
Labels

Comments

@misaochan
Copy link
Member

There was a request on our mailing list:

Hello
It would be great if we can show images up to 1000 or more.
Thank you
Tris T7

While there are bandwidth and memory concerns with downloading large numbers of images, I personally think if the user decides they want to, we should allow it (however the default should remain the same as currently). Currently the max you can set in Settings is 500. Would this be a good idea?

@nicolas-raoul
Copy link
Member

I think the ideal solution would be to implement My Uploads like it is done in Explore:

  1. Load N images
  2. When the scrolling user comes close to the end of these N, load N more. Etc.

@misaochan
Copy link
Member Author

Agreed. Will change the title accordingly.

@misaochan misaochan changed the title Allow users to set recent upload limit to >500 Allow dynamic loading of contributions, without number limit Nov 12, 2018
@maskaravivek
Copy link
Member

I would like to pick this up.

@nicolas-raoul
Copy link
Member

@maskaravivek Don't hesitate to use the "Assignees" button to assign issues to yourself :-)

@maskaravivek
Copy link
Member

The code in contributions fragment and contribution list fragment is quite old and things have been patched on top of it. One of the focus areas of the next grant is to overhaul legacy code(#1092) and introduce a consistent code pattern across the app.

So, before starting working on this talk it would be great if we could finalize the architecture for the presentation layer. Let's continue the discussion for the architecture in #888.

@maskaravivek
Copy link
Member

@ashishkumar468 Recently you refactored the contributions list. Can you confirm if this has already been taken care of?

@ashishkumar468
Copy link
Collaborator

@maskaravivek my refactors did not change the way things were already there. AFAIK I know such things would need pagination at the end of the recycler view which is not there as of now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants