Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codacy or Travis check for lint warnings in PRs? #1880

Open
misaochan opened this issue Sep 4, 2018 · 0 comments
Open

Codacy or Travis check for lint warnings in PRs? #1880

misaochan opened this issue Sep 4, 2018 · 0 comments
Labels
code-quality discussion

Comments

@misaochan
Copy link
Member

misaochan commented Sep 4, 2018 •
edited
Loading

We often realize belatedly that merged PRs contain lint warnings re: potential exceptions, increasing the risk for crashes in production versions after the PRs are merged in. It would be too big a burden to ask our reviewers to manually check the code they are merging for any lint warnings.

Anyone know if we can integrate this check into our Travis or Codacy CIs?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-quality discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@misaochan