Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include peer review to app #1559

Closed
neslihanturan opened this issue May 27, 2018 · 6 comments
Closed

Include peer review to app #1559

neslihanturan opened this issue May 27, 2018 · 6 comments

Comments

@neslihanturan
Copy link
Collaborator

Summary:

As you know, peer review #780 is roughly working. This issue will contain required steps to include it to our master codebase.

  • UI: currently we used a viewpager and at each different question whole page swipes which is bad. I think the part of the page that includes question should move on next question, but image should stay still.
  • UI: Refresh button should change. I didn't think on a better UI yet.
  • UI: Currently transitions between questions and new image is quite similar. But we have 2 different fuction and their transitions should feel different. First transition is when user answered a question about an image , new question comes. Second transition is whenever user requested another image or completed all questions with previous image, we give another image and start to ask questions from first question. My queestion is swiping is enough for first transition, however it could be better to add a fast forward animation for second transition.
  • Compatibility: It would be nice if we can both play with random images and images that we searched for. So, this feature should be usable with images explored on explore feature. We can add them simultaneously.

What do you suggest?

@nicolas-raoul
Copy link
Member

I would be in favor of releasing the feature without spending time polishing it because:

  • Only a few people will try the feature, I guess.
  • Right now there are less than 100 uploads per day, so an inconvenient UI is not a big problem.
  • Maybe we will discover some fundamental things that will require us to completely change how peer review works. So the polishing effort would be in vain.

But I believe we must add a mandatory (shown every time, no way to "skip in the future") one-page long text explanation that details:

  • what peer review is,
  • in case of doubt please skip, only report if you are sure a picture is a violation
  • on the opposite, be generous with the "thanks" button
  • explanation of copyright violation
  • explanation of what is on-topic, off-topic
  • This feature is experimental so the UI is not so great, it is a first iteration/proof-of-concept, but feedback is very welcome on Github Issues
    I can to to write this text, if you want :-)

@nicolas-raoul
Copy link
Member

@neslihanturan By the way, what branch is it in? Would you mind sharing the URL? Thanks :-)

@neslihanturan
Copy link
Collaborator Author

@misaochan
Copy link
Member

misaochan commented Aug 22, 2018

I agree with the steps mentioned by @neslihanturan and @nicolas-raoul - preferably we will polish this a bit before incorporating it in our app, and we need the text explanation. How about we include the polishing as part of our PG 2019 plans?

Also, actually, now that we have the Browse feature... can we reuse that for this purpose?

@nicolas-raoul
Copy link
Member

Recent uploaded are indeed visible within the app: Tap "Explore", search for "Uploaded with Mobile/Android", tap "Categories", tap "Uploaded with Mobile/Android".

Not sure whether this can benefit Nes' work or this feature in general, though.

screenshot_20180822-192957
screenshot_20180822-193029

@nicolas-raoul
Copy link
Member

I believe this is done? :-)
If I am mistaken, feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants