Hide/Show toolbar when scrolling

[knight-shade]

Summary:

In Contribution, Nearby, Notifications and Settings activity the toolbar is in permanent position. It should be hidden/shown according to scrolling.

Steps to reproduce:

• Just go to any of the mentioned activity, and scroll through the list.

Expected behavior:

The toolbar should be hidden/shown for a better immersive experience.

Observed behavior:

The toolbar stays in its permanent position (i.e Top).

Device and Android version:

Android 7.0 Redmi Note 4 MIUI V9

Screen-shots:

Would you like to work on the issue?

Yes, I am working on it.

@misaochan Is it safe now to work with Nearby and Notification activity?

[neslihanturan]

Nearby, not yet. But notification is safe @knight-shade

[psh]

According to the material design spec from Google - https://material.io/guidelines/patterns/scrolling-techniques.html - there are 2 options that are perfectly valid:

• Firstly that the app bar stays where it is and content scrolls under it. This is what is implemented within our app.

• Secondly that the app bar scrolls off (vertically) as you scroll down through content and reappears when you scroll back upward.

I guess I lean toward the "if it isnt broken, dont fix it" camp - this suggestion feels like a change for the sake of change and there are more important things to work on.

[knight-shade]

@psh Ya that sound good, and on a lighter note hide/show toolbar is not working with Frame layout for unknown reason. On the other hand, can you suggest how to make AppBar layout work with framelayout (I need it for another project)?
I have tried nestes scroll view and it doesn't scroll fully.

[nicolas-raoul]

I would argue that as an app targeting photographers we should strive to offer a visually breathtaking experience, so personally I would be in favour of the second option :-)

[misaochan]

I am hesitant to have this for our main (contributions) screen prior to the main screen UI overhaul (#725 ). Currently our camera and gallery buttons are on the toolbar, and they are our main function, so I feel we need to have the toolbar available at all times. After #725 has been implemented, it could be a possibility.

As an interesting note, I tested a few popular apps (Gmail and Evernote), and the toolbar doesn't disappear. I am personally undecided if it would be a beneficial change or not.

Am okay with trialling it out for Settings and Notifications. Though I wonder if it might confuse the user to have some toolbars that disappear and some that don't. :)

[knight-shade]

@nicolas-raoul Exactly why I am in favour of second option.
@misaochan Yup, even I think it would be good after main screen UI overhaul (#725) gets merged. Google photos have hide/show toolbar behaviour, same for Whatsapp as well as linkedin.
Yup, the toolbar behaviour should be consistent across the app.