-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide/Show toolbar when scrolling #1308
Comments
Nearby, not yet. But notification is safe @knight-shade |
According to the material design spec from Google - https://material.io/guidelines/patterns/scrolling-techniques.html - there are 2 options that are perfectly valid:
I guess I lean toward the "if it isnt broken, dont fix it" camp - this suggestion feels like a change for the sake of change and there are more important things to work on. |
@psh Ya that sound good, and on a lighter note hide/show toolbar is not working with Frame layout for unknown reason. On the other hand, can you suggest how to make AppBar layout work with framelayout (I need it for another project)? |
I would argue that as an app targeting photographers we should strive to offer a visually breathtaking experience, so personally I would be in favour of the second option :-) |
I am hesitant to have this for our main (contributions) screen prior to the main screen UI overhaul (#725 ). Currently our camera and gallery buttons are on the toolbar, and they are our main function, so I feel we need to have the toolbar available at all times. After #725 has been implemented, it could be a possibility. As an interesting note, I tested a few popular apps (Gmail and Evernote), and the toolbar doesn't disappear. I am personally undecided if it would be a beneficial change or not. Am okay with trialling it out for Settings and Notifications. Though I wonder if it might confuse the user to have some toolbars that disappear and some that don't. :) |
@nicolas-raoul Exactly why I am in favour of second option. |
Summary:
In Contribution, Nearby, Notifications and Settings activity the toolbar is in permanent position. It should be hidden/shown according to scrolling.
Steps to reproduce:
Expected behavior:
The toolbar should be hidden/shown for a better immersive experience.
Observed behavior:
The toolbar stays in its permanent position (i.e Top).
Device and Android version:
Android 7.0 Redmi Note 4 MIUI V9
Screen-shots:
Would you like to work on the issue?
Yes, I am working on it.
@misaochan Is it safe now to work with Nearby and Notification activity?
The text was updated successfully, but these errors were encountered: