Unit Tests for LocationPickerActivity (#4830)

* LocationPickerActivityUnitTests.kt class created

* Unit tests for LocationPickerActivity

* Unit tests for LocationPickerActivity

* Added verify

* verify added

* Minor changes

* Covered more lines

* Covered more lines

* addCredits test added

Author: Ayan-10

app/src/main/java/fr/free/nrw/commons/LocationPicker/LocationPickerActivity.java

@@ -224,44 +224,57 @@ private void getToolbarUI() {
     @Override
     public void onMapReady(final MapboxMap mapboxMap) {
         this.mapboxMap = mapboxMap;
-        mapboxMap.setStyle(Style.MAPBOX_STREETS, style -> {
-
-            if (modifyLocationButton.getVisibility() == View.VISIBLE) {
-                initDroppedMarker(style);
-                adjustCameraBasedOnOptions();
-                enableLocationComponent(style);
-                if (style.getLayer(DROPPED_MARKER_LAYER_ID) != null) {
-                    final GeoJsonSource source = style.getSourceAs("dropped-marker-source-id");
-                    if (source != null) {
-                        source.setGeoJson(Point.fromLngLat(cameraPosition.target.getLongitude(),
-                            cameraPosition.target.getLatitude()));
-                    }
-                    droppedMarkerLayer = style.getLayer(DROPPED_MARKER_LAYER_ID);
-                    if (droppedMarkerLayer != null) {
-                        droppedMarkerLayer.setProperties(visibility(VISIBLE));
-                        markerImage.setVisibility(View.GONE);
-                        shadow.setVisibility(View.GONE);
-                    }
+        mapboxMap.setStyle(Style.MAPBOX_STREETS, this::onStyleLoaded);
+    }
+
+    /**
+     * Initializes dropped marker and layer
+     * Handles camera position based on options
+     * Enables location components
+     *
+     * @param style style
+     */
+    private void onStyleLoaded(final Style style) {
+        if (modifyLocationButton.getVisibility() == View.VISIBLE) {
+            initDroppedMarker(style);
+            adjustCameraBasedOnOptions();
+            enableLocationComponent(style);
+            if (style.getLayer(DROPPED_MARKER_LAYER_ID) != null) {
+                final GeoJsonSource source = style.getSourceAs("dropped-marker-source-id");
+                if (source != null) {
+                    source.setGeoJson(Point.fromLngLat(cameraPosition.target.getLongitude(),
+                        cameraPosition.target.getLatitude()));
+                }
+                droppedMarkerLayer = style.getLayer(DROPPED_MARKER_LAYER_ID);
+                if (droppedMarkerLayer != null) {
+                    droppedMarkerLayer.setProperties(visibility(VISIBLE));
+                    markerImage.setVisibility(View.GONE);
+                    shadow.setVisibility(View.GONE);
                 }
-            } else {
-                adjustCameraBasedOnOptions();
-                enableLocationComponent(style);
-                bindListeners();
             }
-            modifyLocationButton.setOnClickListener(v -> {
-                placeSelectedButton.setVisibility(View.VISIBLE);
-                modifyLocationButton.setVisibility(View.GONE);
-                showInMapButton.setVisibility(View.GONE);
-                droppedMarkerLayer.setProperties(visibility(NONE));
-                markerImage.setVisibility(View.VISIBLE);
-                shadow.setVisibility(View.VISIBLE);
-                largeToolbarText.setText(getResources().getString(R.string.choose_a_location));
-                smallToolbarText.setText(getResources().getString(R.string.pan_and_zoom_to_adjust));
-                bindListeners();
-            });
-
-            showInMapButton.setOnClickListener(v -> showInMap());
-        });
+        } else {
+            adjustCameraBasedOnOptions();
+            enableLocationComponent(style);
+            bindListeners();
+        }
+
+        modifyLocationButton.setOnClickListener(v -> onClickModifyLocation());
+        showInMapButton.setOnClickListener(v -> showInMap());
+    }
+
+    /**
+     * Handles onclick event of modifyLocationButton
+     */
+    private void onClickModifyLocation() {
+        placeSelectedButton.setVisibility(View.VISIBLE);
+        modifyLocationButton.setVisibility(View.GONE);
+        showInMapButton.setVisibility(View.GONE);
+        droppedMarkerLayer.setProperties(visibility(NONE));
+        markerImage.setVisibility(View.VISIBLE);
+        shadow.setVisibility(View.VISIBLE);
+        largeToolbarText.setText(getResources().getString(R.string.choose_a_location));
+        smallToolbarText.setText(getResources().getString(R.string.pan_and_zoom_to_adjust));
+        bindListeners();
     }
 
     /**
@@ -290,6 +303,7 @@ private void initDroppedMarker(@NonNull final Style loadedMapStyle) {
             iconIgnorePlacement(true)
         ));
     }
+
     /**
      * move the location to the current media coordinates
      */