Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextContentRenderer: Fix overriding of core node rendering #346

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

robinst
Copy link
Collaborator

@robinst robinst commented Oct 6, 2024

It's correct for HTML rendering and there's a test there as well. This adds a test for text content and fixes the behavior. Fixes #166.

Copy link

codecov bot commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.02%. Comparing base (4634a00) to head (cebb010).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #346   +/-   ##
=========================================
  Coverage     95.02%   95.02%           
  Complexity      252      252           
=========================================
  Files           137      137           
  Lines          4380     4380           
  Branches        620      620           
=========================================
  Hits           4162     4162           
  Misses          116      116           
  Partials        102      102           
Files with missing lines Coverage Δ
.../commonmark/renderer/text/TextContentRenderer.java 93.02% <100.00%> (ø)

@robinst robinst merged commit a08d760 into main Oct 6, 2024
12 checks passed
@robinst robinst deleted the issue-166-text-content-renderer-override branch October 6, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TextContentRenderer: How to ignore url in links
1 participant