-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Included documentation of secondary files #318
base: main
Are you sure you want to change the base?
Included documentation of secondary files #318
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick review during lunch break 🏃♂️ Thanks @Mackenzie-OO7 !
@kinow Thanks for reviewing. I've implemented the changes you suggested. |
Hi all - My only concern is 2 things Would be valid in this case |
@tetron can you give your take on secondary files and then merge when we resolve the issue? |
@swzCuroverse I've made some changes, is it okay now? |
@Mackenzie-OO7 could you give this pull request a more descriptive title? The PR title does not indicate that you are added documentation about secondary files. |
Alright. Is it better now? |
Yes, thank you! |
@tetron I've made the changes requested. |
Happy to get you back working on this. I believe the issues is that you are describing what the parser does more than what the user will do in the last section --- Let me make some suggestions on the text. |
This PR: