Remove redundant code

[tom-tan]

As mentioned in #209, the removed code in this PR is never executed.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.01%. Comparing base (8b81c1f) to head (60eca07).
Report is 10 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
+ Coverage   80.50%   81.01%   +0.51%     
==========================================
  Files           8        8              
  Lines         790      785       -5     
  Branches      201      199       -2     
==========================================
  Hits          636      636              
+ Misses        117      113       -4     
+ Partials       37       36       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tom-tan]

Thanks!

Can I try to make a new release?
I already made a API token for PyPI and expect make release works for that.

[mr-c]

Can I try to make a new release?

Sure!

After the distribution is pushed to PyPI and the tag is pushed to GitHub, please make a new release at https://github.com/common-workflow-language/cwltest/releases/new. I use the "Generate release notes" button, and then I edit the result before publishing.

[tom-tan]

Done!

• https://github.com/common-workflow-language/cwltest/releases/tag/2.5.20240709060407

I found that make release depends on the settings in maintainers.
My .gitconfig sets gpgsign = true as shown below. Therefore, git tag forces to make an annotated tag with a GPG key rather than lightweight tag as usual (Sorry, the latest release uses an annotated tag).

[tag]
        gpgsign = true

Although it is harmless, it is better to unify the release process.
I will send a PR to always use lightweight tag for the releases.

[mr-c]

Therefore, git tag forces to make an annotated tag with a GPG key rather than lightweight tag as usual (Sorry, the latest release uses an annotated tag).

What's the downside of an annotated tag versus a lightweight tag?

[tom-tan]

What's the downside of an annotated tag versus a lightweight tag?

It is similar to the annotated commits.

• Annotated tags

  • (Pros) We can verify the annotated tags with a public GPG key by using commands such as git verify-tag
  • (Cons?) Maintainers have to prepare a secret key (e.g., GPG) to sign the tag. In the case of CWL repositories, it is not the problem because we already require the contributors (including the maintainers) to sign the commit with a GPG key.
  • (Cons) They requires an extra message for the tag. I have no idea what kind of messages are useful for them...

• Lightweight tags

  • (Pros) No extra messages are necessary
  • (Pros?) No need to prepare GPG keys
  • (Cons) We cannot verify lightweight tags

[mr-c]

Okay. I have no opinion on the topic. So either way is fine by me.

[tom-tan]

OK, I will send a request to use lightweight tags to follow the existing releases.