Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump commits violates against commitizen #523

Open
anmoel opened this issue Jun 10, 2022 · 1 comment
Open

Bump commits violates against commitizen #523

anmoel opened this issue Jun 10, 2022 · 1 comment

Comments

@anmoel
Copy link

anmoel commented Jun 10, 2022

Description

Hello,

i installed the conventional-pre-commit hook.
After that i tried to create a release with cz bump. It fails because the commit message is not a valid conventional commit.
I expects that commitizen generates only conventional commits, but "bump" is not a valid cmmit type

Steps to reproduce

  1. install pre-commit hook:
repos:
  - repo: https://github.com/compilerla/conventional-pre-commit
    rev: v1.2.0
    hooks:
      - id: conventional-pre-commit
        stages:
          - commit-msg
  1. run cz bump --changelog

Current behavior

bump commit messages starting always with "bump:"

Desired behavior

bump commit messages are valid conventional commits

Screenshots

image

Environment

Commitizen Version: 2.27.1
Python Version: 3.10.4 (main, Apr 26 2022, 19:42:59) [Clang 13.1.6 (clang-1316.0.21.2)]
Operating System: Darwin

@Lee-W
Copy link
Member

Lee-W commented Jul 22, 2022

types other than fix: and feat: are allowed, for example @commitlint/config-conventional (based on the the Angular convention) recommends build:, chore:, ci:, docs:, style:, refactor:, perf:, test:, and others.

according to conventional commit, it's allowed to define our own.

One of the solution I can think of is using bump_message to configure it to something conventional-pre-commit accepts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants