Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option naming should be more consistent #2929

Open
sjakobi opened this issue Jan 16, 2017 · 2 comments
Open

Option naming should be more consistent #2929

sjakobi opened this issue Jan 16, 2017 · 2 comments

Comments

@sjakobi
Copy link
Member

sjakobi commented Jan 16, 2017

Motivated by this SO question I just updated the documentation for the build options.

Here are a few inconsistencies that I noticed:

  • In the yaml config we have test-arguments, haddock-arguments but benchmark-opts.

  • We have test and test-X, haddock and haddock-X, but bench and benchmark-X.

    • --test-arguments -> test-arguments: additional-args
    • --haddock-arguments -> haddock-arguments: haddock-args
    • --benchmark-arguments -> benchmark-opts: benchmark-arguments
  • haddock-deps, open-haddocks and haddock-internal should be inside the haddock-arguments block

  • test additional-args and haddock-arguments each take a list of strings, while benchmark-arguments takes a single string (I didn't check the CLI)

@borsboom
Copy link
Contributor

Related (possibly duplicate?): #652

@mgsloan mgsloan added this to the P3: Optional milestone Jan 31, 2017
@ruuda
Copy link
Contributor

ruuda commented Aug 26, 2019

Another one that I just ran into: we have --ghc-options to pass arguments to GHC, but --{test,haddock,benchmark}-arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants