Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor product importer into sub modules #43

Open
pgbytes opened this issue Sep 22, 2015 · 0 comments
Open

Refactor product importer into sub modules #43

pgbytes opened this issue Sep 22, 2015 · 0 comments

Comments

@pgbytes
Copy link
Contributor

pgbytes commented Sep 22, 2015

  • refactor / simplify _createOrUpdate method.

  • move data preparation methods to a separate module.

  • move reference resolution to a separate module.

  • filter unknown attributes in the beginning of the process, to reduce processing by other methods.

  • process products in sub batches to avoid high number of sku fetching in case of products having high number of variants.

    Promise.map productsToProcess, (p) =>
 skus = @_extractUniqueSkus(p)
# ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pgbytes