Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme bundling with webpack detailing functionality lost #389

Open
mcshaz opened this issue Dec 29, 2022 · 0 comments
Open

Readme bundling with webpack detailing functionality lost #389

mcshaz opened this issue Dec 29, 2022 · 0 comments

Comments

@mcshaz
Copy link

mcshaz commented Dec 29, 2022

Thank you for this great library.

The Bundling with webpack header in the readme states it is worthwhile excluding astronomia and moment/locale dependencies from the build to minimise build size.

Would it be possible to add a couple of lines either in plain text or as comments in the example webpack config as to the downstream effects. For example something like (and clearly I have no idea of the consequences of excluding these 2 dependencies):

// exclude astronomia unless you need to support ???Turkish or ?? holidays
// excluding moment locale will mean all start and end date-times are given in local times on the computer running this library
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant