Fix nondeterministic results when add_noise==disable #4518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #2841 |
|
hope you have better luck than i did! |
mcmonkey4eva
added
the
Good PR
mcmonkey4eva
added
Run-CI-Test
|
(Automated Bot Message) CI Tests are running, you can view the results at https://ci.comfy.org/?branch=4518%2Fmerge |
|
how is this bug still a thing after being reported almost a year ago, multiple people submitting pulls trying to fix the problem. still nothing. i don't get it. it's also a really annoying bug. one of ComfyUI's biggest strengths is being able to iterate and this kills that. |
|
hopefully this is still going to happen. |
blepping
referenced
this pull request
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Images generated by
KSampler (Advanced)andSamplerCustomnodes are nondeterministic whenadd_noiseis set to False.Seems like we need to call
torch.manual_seed(seed)before sampling in order to get deterministic results.You can reproduce this problem by generating multiple times the same image with a fixed seed on ancestral sampler without adding initial noise.
This PR fixes that issue by moving all
torch.zeroscalls insideprepare_noisefunction right after setting torch seed.