Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(p2p)!: Extract TCP transport #4148

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

refactor(p2p)!: Extract TCP transport #4148

wants to merge 4 commits into from

Conversation

melekes
Copy link
Contributor

@melekes melekes commented Sep 21, 2024

So that we can eventually replace it with the QUIC transport.

#go-api-breaking

@melekes melekes self-assigned this Sep 21, 2024
@melekes melekes added p2p breaking A breaking change labels Sep 22, 2024
@cason
Copy link
Contributor

cason commented Sep 26, 2024

A general fast comment here: if we don't rename GetChannels() reactor's method and the type that stores it, we have much less changes and maybe is not (that) API breaking?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking A breaking change p2p
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants