Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.11.2 to 0.11.3 Migration] Breaking change in runClasspath causing issues with precedence (for example tests or resources) #3047

Closed
fabianhjr-dealengine opened this issue Feb 23, 2024 · 1 comment

Comments

@fabianhjr-dealengine
Copy link

https://github.com/com-lihaoyi/mill/blob/0.11.2/scalalib/src/mill/scalalib/JavaModule.scala#L422-L429

vs

https://github.com/com-lihaoyi/mill/blob/0.11.3/scalalib/src/mill/scalalib/JavaModule.scala#L420-L426

From #2735

Causes a breaking change where, for example, a test module has a different resource definition than the main module and doesn't take precedence.

This isn't a request for a fix/change currently making a workaround and experimenting and leaving it in case someone else gets into a similar situation.

@fabianhjr-dealengine
Copy link
Author

Workaround:

override def runClasspath: T[Seq[PathRef]] = T {
    resolvedRunIvyDeps().toSeq ++ localClasspath() ++ transitiveLocalClasspath()
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant