Conversion of a two dimensional array that is ruby 1.8.6 safe. Fix paren warnings too.

Signed-off-by: Michael Koziarski <michael@koziarski.com>

Author: metaskills

activerecord/lib/active_record/associations/association_collection.rb

@@ -383,7 +383,7 @@ def method_missing(method, *args)
             return  send("find_by_#{rest}", *args) ||
                     method_missing("create_by_#{rest}", *args)
           when /^create_by_(.*)$/
-            return create Hash[$1.split('_and_').zip(args)]
+            return create($1.split('_and_').zip(args).inject({}) { |h,kv| k,v=kv ; h[k] = v ; h })
           end
 
           if @target.respond_to?(method) || (!@reflection.klass.respond_to?(method) && Class.respond_to?(method))

activerecord/test/cases/associations/has_many_associations_test.rb

@@ -26,7 +26,7 @@ def test_create_by
     post   = Post.find :first
 
     assert_equal [], person.readers
-    assert_nil person.readers.find_by_post_id post.id
+    assert_nil person.readers.find_by_post_id(post.id)
 
     reader = person.readers.create_by_post_id post.id
 
@@ -55,7 +55,7 @@ def test_find_or_create_by
     post   = Post.find :first
 
     assert_equal [], person.readers
-    assert_nil person.readers.find_by_post_id post.id
+    assert_nil person.readers.find_by_post_id(post.id)
 
     reader = person.readers.find_or_create_by_post_id post.id