Skip to content

Commit 8e9df34

Browse files
committed
Merge branch 'master' of github.com:rails/rails
2 parents dc25138 + b4fd5e6 commit 8e9df34

File tree

19 files changed

+55
-27
lines changed

19 files changed

+55
-27
lines changed

actionmailer/CHANGELOG

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
1+
*Rails 3.0.0 [beta 3] (April 13th, 2010)*
2+
13
* Removed all quoting.rb type files from ActionMailer and put Mail 2.2.0 in instead [ML]
24

35
* Lot of updates to various test cases that now work better with the new Mail and so have different expectations
46

7+
58
*Rails 3.0.0 [beta 2] (April 1st, 2010)*
69

710
* Added interceptors and observers from Mail [ML]

actionmailer/lib/action_mailer/base.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -541,7 +541,7 @@ def mail(headers={}, &block)
541541
wrap_delivery_behavior!(headers.delete(:delivery_method))
542542

543543
# Assign all headers except parts_order, content_type and body
544-
assignable = headers.except(:parts_order, :content_type, :body)
544+
assignable = headers.except(:parts_order, :content_type, :body, :template_name, :template_path)
545545
assignable.each { |k, v| m[k] = v }
546546

547547
# Render the templates and blocks

actionmailer/test/base_test.rb

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -510,28 +510,28 @@ def different_layout(layout_name='')
510510

511511
# Rendering
512512
test "you can specify a different template for implicit render" do
513-
mail = BaseMailer.implicit_different_template('implicit_multipart')
513+
mail = BaseMailer.implicit_different_template('implicit_multipart').deliver
514514
assert_equal("HTML Implicit Multipart", mail.html_part.body.decoded)
515515
assert_equal("TEXT Implicit Multipart", mail.text_part.body.decoded)
516516
end
517517

518518
test "you can specify a different template for explicit render" do
519-
mail = BaseMailer.explicit_different_template('explicit_multipart_templates')
519+
mail = BaseMailer.explicit_different_template('explicit_multipart_templates').deliver
520520
assert_equal("HTML Explicit Multipart Templates", mail.html_part.body.decoded)
521521
assert_equal("TEXT Explicit Multipart Templates", mail.text_part.body.decoded)
522522
end
523523

524524
test "you can specify a different layout" do
525-
mail = BaseMailer.different_layout('different_layout')
525+
mail = BaseMailer.different_layout('different_layout').deliver
526526
assert_equal("HTML -- HTML", mail.html_part.body.decoded)
527527
assert_equal("PLAIN -- PLAIN", mail.text_part.body.decoded)
528528
end
529529

530530
test "you can specify the template path for implicit lookup" do
531-
mail = BaseMailer.welcome_from_another_path('another.path/base_mailer')
531+
mail = BaseMailer.welcome_from_another_path('another.path/base_mailer').deliver
532532
assert_equal("Welcome from another path", mail.body.encoded)
533533

534-
mail = BaseMailer.welcome_from_another_path(['unknown/invalid', 'another.path/base_mailer'])
534+
mail = BaseMailer.welcome_from_another_path(['unknown/invalid', 'another.path/base_mailer']).deliver
535535
assert_equal("Welcome from another path", mail.body.encoded)
536536
end
537537

actionpack/CHANGELOG

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
*Rails 3.0.0 [beta 3] (pending)*
1+
*Rails 3.0.0 [beta 3] (April 13th, 2010)*
22

33
* New option :as added to form_for allows to change the object name. The old <% form_for :client, @post %> becomes <% form_for @post, :as => :client %> [spastorino]
44

actionpack/test/controller/layout_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ def test_layout_status_is_rendered
209209
end
210210
end
211211

212-
unless RUBY_PLATFORM =~ /(:?mswin|mingw|bccwin)/
212+
unless RUBY_PLATFORM =~ /mswin|mingw/
213213
class LayoutSymlinkedTest < LayoutTest
214214
layout "symlinked/symlinked_layout"
215215
end

activemodel/CHANGELOG

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
*Rails 3.0.0 [beta 3] (April 13th, 2010)*
2+
3+
* No changes
4+
5+
16
*Rails 3.0.0 [beta 2] (April 1st, 2010)*
27

38
* #new_record? and #destroyed? were removed from ActiveModel::Lint. Use

activerecord/CHANGELOG

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
*Rails 3.0.0 [Beta 2] (pending)*
1+
*Rails 3.0.0 [beta 3] (April 13th, 2010)*
22

33
* Add Relation extensions. [Pratik Naik]
44

activeresource/CHANGELOG

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
*Rails 3.0.0 [beta 3] (April 13th, 2010)*
2+
3+
* No changes
4+
5+
16
*Rails 3.0.0 [beta 1] (February 4, 2010)*
27

38
* Add support for errors in JSON format. #1956 [Fabien Jakimowicz]

activesupport/CHANGELOG

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
*Rails 3.0.0 [beta 3] (pending)*
1+
*Rails 3.0.0 [beta 3] (April 13th, 2010)*
22

33
* Improve transliteration quality. #4374 [Norman Clarke]
44

activesupport/lib/active_support/core_ext/proc.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
require "active_support/core_ext/object"
1+
require "active_support/core_ext/kernel/singleton_class"
22

33
class Proc #:nodoc:
44
def bind(object)

railties/CHANGELOG

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
1+
*Rails 3.0.0 [beta 3] (April 13th, 2010)*
2+
13
* Renamed config.cookie_secret to config.secret_token and pass it as env key. [JV]
24

5+
36
*Rails 3.0.0 [beta 2] (April 1st, 2010)*
47

58
* Session store configuration has changed [YK & CL]

railties/guides/source/initialization.textile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2636,7 +2636,7 @@ The method +find_with_root_flag+ is defined on +Rails::Engine+ (the superclass o
26362636
root = File.exist?("#{root_path}/#{flag}") ? root_path : default
26372637
raise "Could not find root path for #{self}" unless root
26382638

2639-
RUBY_PLATFORM =~ /(:?mswin|mingw)/ ?
2639+
RUBY_PLATFORM =~ /mswin|mingw/ ?
26402640
Pathname.new(root).expand_path : Pathname.new(root).realpath
26412641
end
26422642
</ruby>

railties/lib/rails/commands/runner.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
opts.on("-h", "--help",
1919
"Show this help message.") { $stderr.puts opts; exit }
2020

21-
if RUBY_PLATFORM !~ /(:?mswin|mingw)/
21+
if RUBY_PLATFORM !~ /mswin|mingw/
2222
opts.separator ""
2323
opts.separator "You can also use runner as a shebang line for your scripts like this:"
2424
opts.separator "-------------------------------------------------------------"

railties/lib/rails/engine.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ def find_root_with_flag(flag, default=nil)
119119
root = File.exist?("#{root_path}/#{flag}") ? root_path : default
120120
raise "Could not find root path for #{self}" unless root
121121

122-
RUBY_PLATFORM =~ /(:?mswin|mingw)/ ?
122+
RUBY_PLATFORM =~ /mswin|mingw/ ?
123123
Pathname.new(root).expand_path : Pathname.new(root).realpath
124124
end
125125
end

railties/lib/rails/generators/erb/scaffold/templates/_form.html.erb

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
<%%= form_for(@<%= singular_name %>) do |f| %>
22
<%% if @<%= singular_name %>.errors.any? %>
3-
<div id="errorExplanation">
4-
<h2><%%= pluralize(@<%= singular_name %>.errors.count, "error") %> prohibited this <%= singular_name %> from being saved:</h2>
5-
<ul>
6-
<%% @<%= singular_name %>.errors.full_messages.each do |msg| %>
7-
<li><%%= msg %></li>
8-
<%% end %>
9-
</ul>
10-
</div>
3+
<div id="error_explanation">
4+
<h2><%%= pluralize(@<%= singular_name %>.errors.count, "error") %> prohibited this <%= singular_name %> from being saved:</h2>
5+
6+
<ul>
7+
<%% @<%= singular_name %>.errors.full_messages.each do |msg| %>
8+
<li><%%= msg %></li>
9+
<%% end %>
10+
</ul>
11+
</div>
1112
<%% end %>
1213

1314
<% for attribute in attributes -%>

railties/lib/rails/generators/rails/app/app_generator.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,7 @@ def mysql_socket
265265
"/opt/local/var/run/mysql4/mysqld.sock", # mac + darwinports + mysql4
266266
"/opt/local/var/run/mysql5/mysqld.sock", # mac + darwinports + mysql5
267267
"/opt/lampp/var/mysql/mysql.sock" # xampp for linux
268-
].find { |f| File.exist?(f) } unless RUBY_PLATFORM =~ /(:?mswin|mingw)/
268+
].find { |f| File.exist?(f) } unless RUBY_PLATFORM =~ /mswin|mingw/
269269
end
270270

271271
def empty_directory_with_gitkeep(destination, config = {})

railties/lib/rails/generators/rails/stylesheets/templates/scaffold.css

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ div.field, div.actions {
3434
display: table;
3535
}
3636

37-
#errorExplanation {
37+
#error_explanation {
3838
width: 450px;
3939
border: 2px solid red;
4040
padding: 7px;
@@ -43,7 +43,7 @@ div.field, div.actions {
4343
background-color: #f0f0f0;
4444
}
4545

46-
#errorExplanation h2 {
46+
#error_explanation h2 {
4747
text-align: left;
4848
font-weight: bold;
4949
padding: 5px 5px 5px 15px;
@@ -54,7 +54,7 @@ div.field, div.actions {
5454
color: #fff;
5555
}
5656

57-
#errorExplanation ul li {
57+
#error_explanation ul li {
5858
font-size: 12px;
5959
list-style: square;
6060
}

railties/lib/rails/test_unit/testing.rake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ end
3030
module Kernel
3131
def silence_stderr
3232
old_stderr = STDERR.dup
33-
STDERR.reopen(RUBY_PLATFORM =~ /(:?mswin|mingw)/ ? 'NUL:' : '/dev/null')
33+
STDERR.reopen(RUBY_PLATFORM =~ /mswin|mingw/ ? 'NUL:' : '/dev/null')
3434
STDERR.sync = true
3535
yield
3636
ensure

release.rb

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
version = ARGV.pop
2+
3+
%w( activesupport activemodel activerecord activeresource actionpack actionmailer railties ).each do |framework|
4+
puts "Building and pushing #{framework}..."
5+
`cd #{framework} && gem build #{framework}.gemspec && gem push #{framework}-#{version}.gem && rm #{framework}-#{version}.gem`
6+
end
7+
8+
puts "Building and pushing Rails..."
9+
`gem build rails.gemspec`
10+
`gem push rails-#{version}.gem`
11+
`rm rails-#{version}.gem`

0 commit comments

Comments
 (0)