Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen mode does not work with wavesurfer plugins #164

Open
Aleksandar-G opened this issue Oct 18, 2022 · 0 comments
Open

Fullscreen mode does not work with wavesurfer plugins #164

Aleksandar-G opened this issue Oct 18, 2022 · 0 comments

Comments

@Aleksandar-G
Copy link

Aleksandar-G commented Oct 18, 2022

Description

Fullscreen mode does not work with wavesurfer plugins

Steps to reproduce

https://codesandbox.io/s/funny-rain-4hiqup

Here I have created a demo to show the bug. You can open the project. Open the browser window on a new tab to enable the fullscreen button and make the video fullscreen and play it. After you have played it you will see that the regions are deleted and a error pops on the screen.

Results

Expected

The fullscreen mode to work and not to crash the application

Actual

After you enter a fullscreen mode and play the video the plugins stop working and a type error is thrown

Error output

Uncaught TypeError: Cannot read properties of null (reading 'scrollWidth')
    at TimelinePlugin.updateCanvases

Versions

Make sure to include the following versions:

videojs/wavesurfer

what version of video.js, videojs-wavesurfer and wavesurfer.js does this occur with?
video.js - 7.20.3
wavesurfer.js - 6.3.0
videojs-wavesurfer - 3.9.0

Browsers

what browser(s) are affected? Make sure to test with all third-party browser extensions disabled.
Google Chrome Version 105.0.5195.125

OSes

what platforms (operating systems and devices) are affected?
Linux Ubuntu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant