Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big Play Button is not visible #161

Open
meusx opened this issue Mar 15, 2022 · 1 comment
Open

Big Play Button is not visible #161

meusx opened this issue Mar 15, 2022 · 1 comment
Labels

Comments

@meusx
Copy link

meusx commented Mar 15, 2022

Description

The play button is not showing using the library as plugins on videojs

Steps to reproduce

options = {
      controls: true,
      autoplay: false,
      fill: true,
      bigPlayButton: true,
      fluid: true,
      playbackRates: [0.5, 1, 1.5, 2],
      nativeControlsForTouch: true,
      html5: {
          nativeControlsForTouch: true,
          nativeAudioTracks: true
      },
      plugins: {
          wavesurfer: {
              waveColor: '#009fd1',
              cursorColor: 'black',
              interact: true,
              barHeight: 0.2,
              backend: 'MediaElement',
              displayMilliseconds: false,
              mediaControls: true,
              barRadius: 26,
              cursorWidth: 1,
              barGap: 26
          }
      }
  };

Results

Expected

When its a video content without wavesurfer the play button shows but with wavesurfer it does not shows

Actual

The play button button after the cotent loads

Error output

None

Versions

Make sure to include the following versions:

videojs/wavesurfer

videojs version : 7.4.;1
videojs-wavesurfer: https://unpkg.com/wavesurfer.js

Browsers

Safari and Chorme (Both on mobile)
Did not try in any other

OSes

Android and IOs

@thijstriemstra
Copy link
Member

The big play button is not used in this videojs plugin because it interferes with the wavesurfer.js instance. This is why It's explicitly disabled in the code

If you comment out that check, and recompile, you will end up with this:

Screenshot from 2022-03-15 16-10-42

It's a button that cannot be clicked, the click events are recieved by the wavesurfer instance instead. Any suggestions to work around this are always welcome.

@thijstriemstra thijstriemstra changed the title Big Play Button still hiding on mobile (Videojs) Big Play Button still hiding (Videojs) Mar 15, 2022
@thijstriemstra thijstriemstra changed the title Big Play Button still hiding (Videojs) Big Play Button is not visible Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants