Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't external be "video.js" and not "videojs" ? #497

Closed
gaspard opened this issue Jul 27, 2020 · 3 comments · Fixed by #501
Closed

Shouldn't external be "video.js" and not "videojs" ? #497

gaspard opened this issue Jul 27, 2020 · 3 comments · Fixed by #501
Labels

Comments

@gaspard
Copy link

gaspard commented Jul 27, 2020

{'video.js': 'videojs'},

The current setting creates invalid "require" calls in compiled JS:

(function webpackUniversalModuleDefinition(root, factory) {
	if(typeof exports === 'object' && typeof module === 'object')
		module.exports = factory(require("RecordRTC"), require("videojs"));
	else if(typeof define === 'function' && define.amd)
		define("VideojsRecord", ["RecordRTC", "videojs"], factory);
	else if(typeof exports === 'object')
		exports["VideojsRecord"] = factory(require("RecordRTC"), require("videojs"));
	else
		root["VideojsRecord"] = factory(root["RecordRTC"], root["videojs"]);
})
@thijstriemstra
Copy link
Member

@gaspard sounds good, please open a pull request!

@thijstriemstra
Copy link
Member

I opened a pull request for this, can you test #501 @gaspard?

@thijstriemstra
Copy link
Member

Fixed in v4.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants