Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3437: extendShape erases JSDoc property documentation #3463

Merged
merged 1 commit into from
May 7, 2024
Merged

Fix #3437: extendShape erases JSDoc property documentation #3463

merged 1 commit into from
May 7, 2024

Conversation

jussisaurio
Copy link
Contributor

Fixes the issue described here, at least the minimal repro example provided.

Benchmarking the change using zod-ts-perftest it increases the number of type instantiations by 8.5%, which may be an acceptable compromise, but ofc not ideal

More discussion here

@netlify Netlify
Copy link

netlify bot commented May 4, 2024 •
edited
Loading

✅ Deploy Preview for guileless-rolypoly-866f8a ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 24d6ca4
🔍 Latest deploy log https://app.netlify.com/sites/guileless-rolypoly-866f8a/deploys/6635e5d43c0aef00085d4e8a
😎 Deploy Preview https://deploy-preview-3463--guileless-rolypoly-866f8a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@colinhacks colinhacks merged commit d969423 into colinhacks:master May 7, 2024
13 checks passed
colinhacks pushed a commit to maurer2/zod that referenced this pull request May 16, 2024
@jussisaurio @colinhacks
Fix colinhacks#3437: extendShape erases JSDoc property documentation (c…
ca6ae1d 
…olinhacks#3463)
@carltrepanier carltrepanier mentioned this pull request May 28, 2024
Merged
@pshaddel pshaddel mentioned this pull request May 28, 2024
Open
@b34c0n5 b34c0n5 mentioned this pull request May 28, 2024
Merged
@lryanle lryanle mentioned this pull request May 29, 2024
Open
@Eiromplays Eiromplays mentioned this pull request May 29, 2024
Open
@bilelsalemdev bilelsalemdev mentioned this pull request May 29, 2024
Open
@JoaoManoelFontes JoaoManoelFontes mentioned this pull request May 29, 2024
Open
@pshaddel pshaddel mentioned this pull request May 29, 2024
Open
@b34c0n5 b34c0n5 mentioned this pull request May 29, 2024
Closed
@Eiromplays Eiromplays mentioned this pull request May 30, 2024
Open
@NiallJoeMaher NiallJoeMaher mentioned this pull request May 30, 2024
Merged
@eriklopess eriklopess mentioned this pull request May 30, 2024
Open
@Niraj-Dilshan Niraj-Dilshan mentioned this pull request May 30, 2024
Open
@JonasLang-dev JonasLang-dev mentioned this pull request May 30, 2024
Open
@bilelsalemdev bilelsalemdev mentioned this pull request May 30, 2024
Open
@carltrepanier carltrepanier mentioned this pull request May 30, 2024
Merged
@vigneshshettyin vigneshshettyin mentioned this pull request May 31, 2024
Merged
@lryanle lryanle mentioned this pull request May 31, 2024
Open
@PropTekCTO PropTekCTO mentioned this pull request Jun 1, 2024
Open
@IDOTITOLDYASUCKAS IDOTITOLDYASUCKAS mentioned this pull request Jun 1, 2024
Open
@will0684 will0684 mentioned this pull request Jun 1, 2024
Merged
@sandermendes sandermendes mentioned this pull request Jun 2, 2024
Open
@hawlader-imtiaz hawlader-imtiaz mentioned this pull request Jun 4, 2024
Open
@pshaddel pshaddel mentioned this pull request Jun 5, 2024
Open
@ashramwen ashramwen mentioned this pull request Jun 5, 2024
Open
@thearyadev thearyadev mentioned this pull request Jun 6, 2024
Closed
This was referenced Aug 22, 2024
Open
Open
Open
Open
This was referenced Aug 22, 2024
Open
Open
@Niraj-Dilshan Niraj-Dilshan mentioned this pull request Aug 29, 2024
Open
This was referenced Aug 29, 2024
Open
Open
Open
@JoaoManoelFontes JoaoManoelFontes mentioned this pull request Aug 31, 2024
Open
@PoojaPanchal12 PoojaPanchal12 mentioned this pull request Aug 31, 2024
Open
@sandeepdsvs sandeepdsvs mentioned this pull request Sep 6, 2024
Closed
@dyetto dyetto mentioned this pull request Sep 6, 2024
Open
@eriklopess eriklopess mentioned this pull request Sep 7, 2024
Open
@Ocor17 Ocor17 mentioned this pull request Sep 9, 2024
Open
@anandanshul anandanshul mentioned this pull request Sep 11, 2024
Open
@JoaoManoelFontes JoaoManoelFontes mentioned this pull request Sep 13, 2024
Open
This was referenced Sep 14, 2024
Open
Open
@cibedex cibedex mentioned this pull request Sep 24, 2024
Open
@JonasLang-dev JonasLang-dev mentioned this pull request Sep 24, 2024
Open
@THamza THamza mentioned this pull request Sep 28, 2024
Open
This was referenced Sep 28, 2024
Open
Open
@junjiepro junjiepro mentioned this pull request Oct 2, 2024
Open
@sandeepdsvs sandeepdsvs mentioned this pull request Oct 4, 2024
Open
@tobiaslafleur tobiaslafleur mentioned this pull request Oct 31, 2024
Open
@gabrielborgesdm gabrielborgesdm mentioned this pull request Nov 1, 2024
Open
@iamaffanyasir iamaffanyasir mentioned this pull request Nov 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jussisaurio @colinhacks