Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing balance_exemptions in /network/options -> allow #93

Open
fboucquez opened this issue Jan 31, 2022 · 1 comment
Open

Missing balance_exemptions in /network/options -> allow #93

fboucquez opened this issue Jan 31, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@fboucquez
Copy link

Hi team,

According to https://github.com/coinbase/rosetta-specifications/blob/master/models/Allow.yaml#L28,

The balance_exemptions is required in the Options's Allow entity. The field is missing in the following service implementation:

https://github.com/coinbase/rosetta-ethereum/blob/master/services/network_service.go#L65

Note that BalanceExemption could be an empty object!

There is a bit of inconsistency. 2 possible fixes:

  • Fix the service by adding balance_exemptions. That field could even be an empty object.
  • Remove balance_exemptions from required in the openapi spec.

I know that in general, this is not a big issue, a client app can just ignore the missing balance_exemptions. In my case, I'm using generated typescript clients using openapi generator. The parser breaks the whole call because it expects the field to be present.

Thanks!
Fernando

@fboucquez fboucquez added the bug Something isn't working label Jan 31, 2022
@shrimalmadhur
Copy link
Contributor

Thanks for raising this. We will take a look to see what's the best way so that parser doesn't break for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants