Add code review feedback

drohit-cb · drohit-cb · commit 7e97464d7358 · 2024-08-15T07:55:11.000-07:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@
 ### Added
 
 - Add toAddressId() method to Transaction class
+- Remove "pending" status from StakingOperationStatusEnum
 
 ## [0.0.16] - 2024-08-14
 
diff --git a/src/coinbase/transaction.ts b/src/coinbase/transaction.ts
@@ -80,12 +80,12 @@ export class Transaction {
   }
 
   /**
-   * Returns the To Address ID for the Transaction.
+   * Returns the To Address ID for the Transaction if it's available.
    *
    * @returns The To Address ID
    */
-  toAddressId(): string {
-    return this.model.to_address_id || "";
+  toAddressId(): string | undefined {
+    return this.model.to_address_id;
   }
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -80,12 +80,12 @@ export class Transaction {`
`80`	`80`	`}`
`81`	`81`
`82`	`82`	`/**`
`83`		`- * Returns the To Address ID for the Transaction.`
	`83`	`+ * Returns the To Address ID for the Transaction if it's available.`
`84`	`84`	`*`
`85`	`85`	`* @returns The To Address ID`
`86`	`86`	`*/`
`87`		`- toAddressId(): string {`
`88`		`- return this.model.to_address_id \|\| "";`
	`87`	`+ toAddressId(): string \| undefined {`
	`88`	`+ return this.model.to_address_id;`
`89`	`89`	`}`
`90`	`90`
`91`	`91`	`/**`