Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generating vase template project with a kebab-case project name results in inconstant naming of the service.edn file #89

Open
CalebMacdonaldBlack opened this issue Mar 30, 2018 · 1 comment

Comments

@CalebMacdonaldBlack
Copy link
Contributor

Description

Generating a vase template project with a kebab-case project name results in inconstant naming of the service.edn file. For example, running lein new vase foo-bar creates the file resources/foo-bar_service.edn with hyphens and underscores.

I'm aware that namespaces must be separated by hyphen and have a corresponding filename separated by an underscore in order to work at all. And that the service.edn is just a file that is read and is not required to follow that patten at all and will work anyway.

I do believe it should be consistent though and sanitising the namespace as is done with clj filenames will make this file look a little less strange when generated.

Expected Behavior

Running lein new vase foo-bar creates the file resources/foo_bar_service.edn

Actual Behavior

Running lein new vase foo-bar creates the file resources/foo-bar_service.edn

I can submit a PR to fix this if this change is wanted.

@mtnygard
Copy link
Contributor

A PR would be most welcome. But since EDN files don't need to be underscored like classnames, I'd rather see resources/foo-bar-service.edn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants